ensure create_hls runs only after all encodings finish #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll need to have another look on this, as a quick fix I've commited 5a1e4f2 and released v4.2.0 Can you sync this branch, since there's a conflict to tasks.py? Thanks |
bobcarroll
force-pushed
the
fix-create-hls
branch
from
3da3898 to
b48eaec
Compare
|
@mgogoulos done |
|
this is good work, however i'm thinking what could be the implications, fore example
I think what is needed here is a special handling of tasks.create_hls in order to do two things:
what we do now, run Bento with all files, can be optimizing with running with specific files only. I think that's a better solution in the long term |
|
would that solution work for you @bobcarroll ? and if so , do you have capacity to work on it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch addresses #929 and #962 by ensuring that
create_hlsonly runs Bento after all h264 encodings are finished. #957 may be fixed by this too as higher resolution encodings won't appear in the player selection without HLS.Calling Bento with more than one media file doesn't work because the
filesargument is interpreted as a single (quoted) value. It seems like the original intention may have been to generate HLS files as each encoding finishes, and this case wasn't triggered until I eliminated duplicate runs of Bento.#938 didn't fix the problem for me.
create_hlswas (indirectly) being called from line 1588 offiles/models.pyand all of my uploads were failing to encode regardless of size. The encoded files were still created and visible in the web UI, with the exception of higher resolution encodings.Steps
Upload a video file with Bento installed and properly configured.